1704 cmyk plotting and threshold#1705
Merged
Merged
Conversation
Updating import statements to get <function> from plantcv, instead of importing plantcv as pcv and calling pcv.<function>
Improve readability. Rename ch_x and ch_y to the actual argument names x_channel and y_channel.
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
param paths_to_imgs must specifically be a list of str (can be a list of one), not a str itself. Passing just a string sets the path for reading to the first character of the string.
And update the test to include cmyk channels
NMiklave
added
enhancement
Update threshold_methods to use new rbg conversion helper functions
…/danforthcenter/plantcv into 1704-cmyk-plotting-and-threshold
nfahlgren
approved these changes
Jun 10, 2025
Member
|
@all-contributors please add @NMiklave for code |
Contributor
|
I've put up a pull request to add @NMiklave! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
visualize.pixel_scatter_vis.pixel_scatter_plotandthreshold.threshold_methods.dual_channels.threshold.threshold_methods.dual_channelsdocstring to match argument names forx_channelandy_channel.visualize.pixel_scatter_visto remove circular imports and match format in other functions.A clear and concise description of what changes are made by this pull request.
What was the previous functionality (if relevant) and what can we do now with
these changes.
Type of update
Bug fix / feature enhancement
Associated issues
Closes: #1704
Additional context
None
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md